diff --git a/src/Services/Basket/Basket.API/Startup.cs b/src/Services/Basket/Basket.API/Startup.cs index 082560048..4dc01fff2 100644 --- a/src/Services/Basket/Basket.API/Startup.cs +++ b/src/Services/Basket/Basket.API/Startup.cs @@ -242,11 +242,11 @@ public class Startup var serviceBusPersisterConnection = sp.GetRequiredService(); var iLifetimeScope = sp.GetRequiredService(); var logger = sp.GetRequiredService>(); - var eventBusSubcriptionsManager = sp.GetRequiredService(); + var eventBusSubscriptionsManager = sp.GetRequiredService(); string subscriptionName = Configuration["SubscriptionClientName"]; return new EventBusServiceBus(serviceBusPersisterConnection, logger, - eventBusSubcriptionsManager, iLifetimeScope, subscriptionName); + eventBusSubscriptionsManager, iLifetimeScope, subscriptionName); }); } else @@ -257,7 +257,7 @@ public class Startup var rabbitMQPersistentConnection = sp.GetRequiredService(); var iLifetimeScope = sp.GetRequiredService(); var logger = sp.GetRequiredService>(); - var eventBusSubcriptionsManager = sp.GetRequiredService(); + var eventBusSubscriptionsManager = sp.GetRequiredService(); var retryCount = 5; if (!string.IsNullOrEmpty(Configuration["EventBusRetryCount"])) @@ -265,7 +265,7 @@ public class Startup retryCount = int.Parse(Configuration["EventBusRetryCount"]); } - return new EventBusRabbitMQ(rabbitMQPersistentConnection, logger, iLifetimeScope, eventBusSubcriptionsManager, subscriptionClientName, retryCount); + return new EventBusRabbitMQ(rabbitMQPersistentConnection, logger, iLifetimeScope, eventBusSubscriptionsManager, subscriptionClientName, retryCount); }); } diff --git a/src/Services/Identity/Identity.API/Services/RedirectService.cs b/src/Services/Identity/Identity.API/Services/RedirectService.cs index 4f35e1e92..21deefb0c 100644 --- a/src/Services/Identity/Identity.API/Services/RedirectService.cs +++ b/src/Services/Identity/Identity.API/Services/RedirectService.cs @@ -4,15 +4,14 @@ { public string ExtractRedirectUriFromReturnUrl(string url) { - var result = ""; var decodedUrl = System.Net.WebUtility.HtmlDecode(url); var results = Regex.Split(decodedUrl, "redirect_uri="); if (results.Length < 2) return ""; - result = results[1]; + string result = results[1]; - var splitKey = ""; + string splitKey; if (result.Contains("signin-oidc")) splitKey = "signin-oidc"; else diff --git a/src/Services/Ordering/Ordering.API/Application/Behaviors/TransactionBehaviour.cs b/src/Services/Ordering/Ordering.API/Application/Behaviors/TransactionBehaviour.cs index 24949869e..14e733b76 100644 --- a/src/Services/Ordering/Ordering.API/Application/Behaviors/TransactionBehaviour.cs +++ b/src/Services/Ordering/Ordering.API/Application/Behaviors/TransactionBehaviour.cs @@ -35,7 +35,7 @@ public class TransactionBehaviour : IPipelineBehavior options.JsonSerializerOptions.WriteIndented = true) - .SetCompatibilityVersion(CompatibilityVersion.Version_3_0); + .AddJsonOptions(options => options.JsonSerializerOptions.WriteIndented = true); services.AddCors(options => { diff --git a/src/Services/Ordering/Ordering.Domain/GlobalUsings.cs b/src/Services/Ordering/Ordering.Domain/GlobalUsings.cs index bc11cd71b..33d18f36e 100644 --- a/src/Services/Ordering/Ordering.Domain/GlobalUsings.cs +++ b/src/Services/Ordering/Ordering.Domain/GlobalUsings.cs @@ -4,7 +4,6 @@ global using Microsoft.eShopOnContainers.Services.Ordering.Domain.Seedwork; global using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.BuyerAggregate; global using Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.OrderAggregate; global using Microsoft.eShopOnContainers.Services.Ordering.Domain.Events; -global using Microsoft.eShopOnContainers.Services.Ordering.Domain.Exceptions; global using System.Collections.Generic; global using System.Linq; global using System.Reflection; diff --git a/src/Services/Ordering/Ordering.Domain/Ordering.Domain.csproj b/src/Services/Ordering/Ordering.Domain/Ordering.Domain.csproj index 7ca0dc00f..994789d3b 100644 --- a/src/Services/Ordering/Ordering.Domain/Ordering.Domain.csproj +++ b/src/Services/Ordering/Ordering.Domain/Ordering.Domain.csproj @@ -10,8 +10,4 @@ - - - - diff --git a/src/Services/Ordering/Ordering.Infrastructure/Ordering.Infrastructure.csproj b/src/Services/Ordering/Ordering.Infrastructure/Ordering.Infrastructure.csproj index 4c5385d09..f09024baa 100644 --- a/src/Services/Ordering/Ordering.Infrastructure/Ordering.Infrastructure.csproj +++ b/src/Services/Ordering/Ordering.Infrastructure/Ordering.Infrastructure.csproj @@ -16,8 +16,4 @@ - - - - diff --git a/src/Services/Ordering/Ordering.Infrastructure/OrderingContext.cs b/src/Services/Ordering/Ordering.Infrastructure/OrderingContext.cs index 243cfadf1..3edbfbc8d 100644 --- a/src/Services/Ordering/Ordering.Infrastructure/OrderingContext.cs +++ b/src/Services/Ordering/Ordering.Infrastructure/OrderingContext.cs @@ -72,7 +72,7 @@ public class OrderingContext : DbContext, IUnitOfWork try { await SaveChangesAsync(); - transaction.Commit(); + await transaction.CommitAsync(); } catch { @@ -128,7 +128,7 @@ public class OrderingContextDesignFactory : IDesignTimeDbContextFactory); } - public Task Publish(TNotification notification, CancellationToken cancellationToken = default(CancellationToken)) where TNotification : INotification + public Task Publish(TNotification notification, CancellationToken cancellationToken = default) where TNotification : INotification { return Task.CompletedTask; } @@ -138,7 +138,7 @@ public class OrderingContextDesignFactory : IDesignTimeDbContextFactory Send(IRequest request, CancellationToken cancellationToken = default(CancellationToken)) + public Task Send(IRequest request, CancellationToken cancellationToken = default) { return Task.FromResult(default(TResponse)); } diff --git a/src/Services/Ordering/Ordering.Infrastructure/Repositories/BuyerRepository.cs b/src/Services/Ordering/Ordering.Infrastructure/Repositories/BuyerRepository.cs index 648d2ea09..9c8dba0f5 100644 --- a/src/Services/Ordering/Ordering.Infrastructure/Repositories/BuyerRepository.cs +++ b/src/Services/Ordering/Ordering.Infrastructure/Repositories/BuyerRepository.cs @@ -19,10 +19,8 @@ public class BuyerRepository .Add(buyer) .Entity; } - else - { - return buyer; - } + + return buyer; } public Buyer Update(Buyer buyer) diff --git a/src/Services/Ordering/Ordering.SignalrHub/GlobalUsings.cs b/src/Services/Ordering/Ordering.SignalrHub/GlobalUsings.cs index 5a5a12391..5cdca9345 100644 --- a/src/Services/Ordering/Ordering.SignalrHub/GlobalUsings.cs +++ b/src/Services/Ordering/Ordering.SignalrHub/GlobalUsings.cs @@ -22,8 +22,6 @@ global using Microsoft.Extensions.Diagnostics.HealthChecks; global using Microsoft.Extensions.Logging; global using Microsoft.eShopOnContainers.Services.Ordering.SignalrHub.AutofacModules; global using Microsoft.eShopOnContainers.Services.Ordering.SignalrHub.IntegrationEvents.EventHandling; -global using Microsoft.eShopOnContainers.Services.Ordering.SignalrHub.IntegrationEvents.Events; -global using Microsoft.eShopOnContainers.Services.Ordering.SignalrHub.IntegrationEvents; global using Microsoft.eShopOnContainers.Services.Ordering.SignalrHub; global using RabbitMQ.Client; global using Serilog.Context; diff --git a/src/Services/Ordering/Ordering.SignalrHub/Ordering.SignalrHub.csproj b/src/Services/Ordering/Ordering.SignalrHub/Ordering.SignalrHub.csproj index 9b9579855..bdf40a7de 100644 --- a/src/Services/Ordering/Ordering.SignalrHub/Ordering.SignalrHub.csproj +++ b/src/Services/Ordering/Ordering.SignalrHub/Ordering.SignalrHub.csproj @@ -7,11 +7,7 @@ true - - - - - + diff --git a/src/Services/Webhooks/Webhooks.API/Controllers/WebhooksController.cs b/src/Services/Webhooks/Webhooks.API/Controllers/WebhooksController.cs index ed5eed705..5f9513480 100644 --- a/src/Services/Webhooks/Webhooks.API/Controllers/WebhooksController.cs +++ b/src/Services/Webhooks/Webhooks.API/Controllers/WebhooksController.cs @@ -52,9 +52,6 @@ public class WebhooksController : ControllerBase return ValidationProblem(ModelState); } - var userId = _identityService.GetUserIdentity(); - - var grantOk = await _grantUrlTester.TestGrantUrl(request.Url, request.GrantUrl, request.Token ?? string.Empty); if (grantOk) diff --git a/src/Web/WebMVC/Startup.cs b/src/Web/WebMVC/Startup.cs index 405d2ced4..b42b0bc28 100644 --- a/src/Web/WebMVC/Startup.cs +++ b/src/Web/WebMVC/Startup.cs @@ -22,8 +22,6 @@ public class Startup IdentityModelEventSource.ShowPII = true; // Caution! Do NOT use in production: https://aka.ms/IdentityModel/PII - services.AddControllers(); - services.AddCustomAuthentication(Configuration); } diff --git a/src/Web/WebStatus/Startup.cs b/src/Web/WebStatus/Startup.cs index a91777ee4..40e4e4c8b 100644 --- a/src/Web/WebStatus/Startup.cs +++ b/src/Web/WebStatus/Startup.cs @@ -13,8 +13,8 @@ public class Startup public void ConfigureServices(IServiceCollection services) { RegisterAppInsights(services); - - services.AddControllers(); + + services.AddMvc(); services.AddOptions(); services.AddHealthChecks() @@ -23,9 +23,6 @@ public class Startup services .AddHealthChecksUI() .AddInMemoryStorage(); - - services.AddMvc() - .SetCompatibilityVersion(CompatibilityVersion.Version_3_0); } // This method gets called by the runtime. Use this method to configure the HTTP request pipeline. diff --git a/src/Web/WebhookClient/Startup.cs b/src/Web/WebhookClient/Startup.cs index 8a3771c99..cee8309cc 100644 --- a/src/Web/WebhookClient/Startup.cs +++ b/src/Web/WebhookClient/Startup.cs @@ -21,8 +21,7 @@ public class Startup .AddCustomAuthentication(Configuration) .AddTransient() .AddSingleton() - .AddMvc() - .SetCompatibilityVersion(CompatibilityVersion.Version_3_0); + .AddMvc(); services.AddControllers(); }