From 488c607a7e67b7f444f5f461bcf679b5015445e9 Mon Sep 17 00:00:00 2001 From: Petr Onderka Date: Sun, 12 Aug 2018 14:44:04 +0200 Subject: [PATCH] Update Enumeration --- .../AggregatesModel/OrderAggregate/OrderStatus.cs | 4 ---- .../Ordering/Ordering.Domain/SeedWork/Enumeration.cs | 11 ++++------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/OrderStatus.cs b/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/OrderStatus.cs index bc07635ae..0e3c1abf0 100644 --- a/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/OrderStatus.cs +++ b/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/OrderStatus.cs @@ -17,10 +17,6 @@ public static OrderStatus Shipped = new OrderStatus(5, nameof(Shipped).ToLowerInvariant()); public static OrderStatus Cancelled = new OrderStatus(6, nameof(Cancelled).ToLowerInvariant()); - protected OrderStatus() - { - } - public OrderStatus(int id, string name) : base(id, name) { diff --git a/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs b/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs index a1e4c4c7e..c2cbb3487 100644 --- a/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs +++ b/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs @@ -7,12 +7,9 @@ namespace Microsoft.eShopOnContainers.Services.Ordering.Domain.SeedWork { public abstract class Enumeration : IComparable { - public string Name { get; private set; } + public string Name { get; } - public int Id { get; private set; } - - protected Enumeration() - { } + public int Id { get; } protected Enumeration(int id, string name) { @@ -36,8 +33,8 @@ namespace Microsoft.eShopOnContainers.Services.Ordering.Domain.SeedWork if (otherValue == null) return false; - var typeMatches = GetType().Equals(obj.GetType()); - var valueMatches = Id.Equals(otherValue.Id); + var typeMatches = GetType() == obj.GetType(); + var valueMatches = Id == otherValue.Id; return typeMatches && valueMatches; }