Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

src/ApiGateways/Web.Bff.Shopping/aggregator/Filters/AuthorizeCheckOperationFilter.cs

@@ -24,7 +24,7 @@
             {
                 new OpenApiSecurityRequirement
                 {
-                    [ oAuthScheme ] = new [] { "Microsoft.eShopOnContainers.Web.Shopping.HttpAggregator" }
+                    [ oAuthScheme ] = new[] { "Microsoft.eShopOnContainers.Web.Shopping.HttpAggregator" }
                 }
             };
             }

src/ApiGateways/Web.Bff.Shopping/aggregator/Infrastructure/GrpcExceptionInterceptor.cs

@@ -19,11 +19,11 @@ public class GrpcExceptionInterceptor : Interceptor
         return new AsyncUnaryCall<TResponse>(HandleResponse(call.ResponseAsync), call.ResponseHeadersAsync, call.GetStatus, call.GetTrailers, call.Dispose);
     }
 
-    private async Task<TResponse> HandleResponse<TResponse>(Task<TResponse> t)
+    private async Task<TResponse> HandleResponse<TResponse>(Task<TResponse> task)
     {
         try
         {
-            var response = await t;
+            var response = await task;
             return response;
         }
         catch (RpcException e)

src/ApiGateways/Web.Bff.Shopping/aggregator/Infrastructure/HttpClientAuthorizationDelegatingHandler.cs

@@ -15,12 +15,12 @@ public class HttpClientAuthorizationDelegatingHandler
         var authorizationHeader = _httpContextAccessor.HttpContext
             .Request.Headers["Authorization"];
 
-        if (!string.IsNullOrEmpty(authorizationHeader))
+        if (!string.IsNullOrWhitespace(authorizationHeader))
         {
             request.Headers.Add("Authorization", new List<string>() { authorizationHeader });
         }
 
-        var token = await GetToken();
+        var token = await GetTokenAsync();
 
         if (token != null)
         {
@@ -30,11 +30,11 @@ public class HttpClientAuthorizationDelegatingHandler
         return await base.SendAsync(request, cancellationToken);
     }
 
-    async Task<string> GetToken()
+    Task<string> GetTokenAsync()
     {
         const string ACCESS_TOKEN = "access_token";
 
-        return await _httpContextAccessor.HttpContext
+        return _httpContextAccessor.HttpContext
             .GetTokenAsync(ACCESS_TOKEN);
     }
 }

src/ApiGateways/Web.Bff.Shopping/aggregator/Models/BasketData.cs

@@ -4,7 +4,7 @@ public class BasketData
 {
     public string BuyerId { get; set; }
 
-    public List<BasketDataItem> Items { get; set; } = new List<BasketDataItem>();
+    public List<BasketDataItem> Items { get; set; } = new();
 
     public BasketData()
     {

src/ApiGateways/Web.Bff.Shopping/aggregator/Models/OrderData.cs

@@ -38,6 +38,6 @@ public class OrderData
 
     public string Buyer { get; set; }
 
-    public List<OrderItemData> OrderItems { get; } = new List<OrderItemData>();
+    public List<OrderItemData> OrderItems { get; } = new();
 }
 

src/ApiGateways/Web.Bff.Shopping/aggregator/Models/UpdateBasketItemData.cs

@@ -6,8 +6,4 @@ public class UpdateBasketItemData
 
     public int NewQty { get; set; }
 
-    public UpdateBasketItemData()
-    {
-        NewQty = 0;
-    }
 }

src/ApiGateways/Web.Bff.Shopping/aggregator/Program.cs

@@ -1,4 +1,4 @@
-BuildWebHost(args).Run();
+await BuildWebHost(args).RunAsync();
 
 IWebHost BuildWebHost(string[] args) =>
     WebHost

src/ApiGateways/Web.Bff.Shopping/aggregator/Services/IBasketService.cs

@@ -2,7 +2,7 @@
 
 public interface IBasketService
 {
-    Task<BasketData> GetById(string id);
+    Task<BasketData> GetByIdAsync(string id);
 
     Task UpdateAsync(BasketData currentBasket);
 }