From 7afe822e1658e4dc393df338700772a9a40caa8d Mon Sep 17 00:00:00 2001 From: Bradley Grainger Date: Fri, 3 Nov 2017 12:14:44 -0700 Subject: [PATCH 1/3] Fix incorrect return type. The interface's methods were changed in 5e1346731561fd0612cf76ec7fe4e34cf32ebb00. --- .../UnitTest/Ordering/Application/OrdersWebApiTest.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Services/UnitTest/Ordering/Application/OrdersWebApiTest.cs b/test/Services/UnitTest/Ordering/Application/OrdersWebApiTest.cs index d1c981334..b6f047960 100644 --- a/test/Services/UnitTest/Ordering/Application/OrdersWebApiTest.cs +++ b/test/Services/UnitTest/Ordering/Application/OrdersWebApiTest.cs @@ -93,7 +93,7 @@ namespace UnitTest.Ordering.Application public async Task Get_orders_success() { //Arrange - var fakeDynamicResult = Enumerable.Empty(); + var fakeDynamicResult = Enumerable.Empty(); _orderQueriesMock.Setup(x => x.GetOrdersAsync()) .Returns(Task.FromResult(fakeDynamicResult)); @@ -110,7 +110,7 @@ namespace UnitTest.Ordering.Application { //Arrange var fakeOrderId = 123; - var fakeDynamicResult = new Object(); + var fakeDynamicResult = new Order(); _orderQueriesMock.Setup(x => x.GetOrderAsync(It.IsAny())) .Returns(Task.FromResult(fakeDynamicResult)); @@ -126,7 +126,7 @@ namespace UnitTest.Ordering.Application public async Task Get_cardTypes_success() { //Arrange - var fakeDynamicResult = Enumerable.Empty(); + var fakeDynamicResult = Enumerable.Empty(); _orderQueriesMock.Setup(x => x.GetCardTypesAsync()) .Returns(Task.FromResult(fakeDynamicResult)); From f42c32c63b3a986c22541edc64666840001a30aa Mon Sep 17 00:00:00 2001 From: Bradley Grainger Date: Fri, 3 Nov 2017 12:14:59 -0700 Subject: [PATCH 2/3] Fix xUnit warnings. --- .../Services/Basket/RedisBasketRepositoryTests.cs | 2 +- .../IntegrationTests/Services/Catalog/CatalogScenarios.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Services/IntegrationTests/Services/Basket/RedisBasketRepositoryTests.cs b/test/Services/IntegrationTests/Services/Basket/RedisBasketRepositoryTests.cs index 5dd46c5f0..9eefde0d5 100644 --- a/test/Services/IntegrationTests/Services/Basket/RedisBasketRepositoryTests.cs +++ b/test/Services/IntegrationTests/Services/Basket/RedisBasketRepositoryTests.cs @@ -31,7 +31,7 @@ }); Assert.NotNull(basket); - Assert.Equal(1, basket.Items.Count); + Assert.Single(basket.Items); } [Fact] diff --git a/test/Services/IntegrationTests/Services/Catalog/CatalogScenarios.cs b/test/Services/IntegrationTests/Services/Catalog/CatalogScenarios.cs index 493665cde..6414a57ea 100644 --- a/test/Services/IntegrationTests/Services/Catalog/CatalogScenarios.cs +++ b/test/Services/IntegrationTests/Services/Catalog/CatalogScenarios.cs @@ -41,7 +41,7 @@ namespace IntegrationTests.Services.Catalog var response = await server.CreateClient() .GetAsync(Get.ItemById(int.MinValue)); - Assert.Equal(response.StatusCode, HttpStatusCode.BadRequest); + Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode); } } @@ -53,7 +53,7 @@ namespace IntegrationTests.Services.Catalog var response = await server.CreateClient() .GetAsync(Get.ItemById(int.MaxValue)); - Assert.Equal(response.StatusCode, HttpStatusCode.NotFound); + Assert.Equal( HttpStatusCode.NotFound, response.StatusCode); } } From c75fba052bd48627f8ea7b5128b193a7d9250878 Mon Sep 17 00:00:00 2001 From: Bradley Grainger Date: Fri, 3 Nov 2017 12:15:14 -0700 Subject: [PATCH 3/3] Fix unused variable compiler warning. --- test/Services/UnitTest/Ordering/Domain/OrderAggregateTest.cs | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/Services/UnitTest/Ordering/Domain/OrderAggregateTest.cs b/test/Services/UnitTest/Ordering/Domain/OrderAggregateTest.cs index eaa0d0cb6..e2072e352 100644 --- a/test/Services/UnitTest/Ordering/Domain/OrderAggregateTest.cs +++ b/test/Services/UnitTest/Ordering/Domain/OrderAggregateTest.cs @@ -111,7 +111,6 @@ public class OrderAggregateTest public void Add_new_Order_raises_new_event() { //Arrange - var userId = new Guid(); var street = "fakeStreet"; var city = "FakeCity"; var state = "fakeState"; @@ -135,7 +134,6 @@ public class OrderAggregateTest public void Add_event_Order_explicitly_raises_new_event() { //Arrange - var userId = new Guid(); var street = "fakeStreet"; var city = "FakeCity"; var state = "fakeState"; @@ -159,7 +157,6 @@ public class OrderAggregateTest public void Remove_event_Order_explicitly() { //Arrange - var userId = new Guid(); var street = "fakeStreet"; var city = "FakeCity"; var state = "fakeState";