Address PR feedback
This commit is contained in:
		
							parent
							
								
									42e161d1f9
								
							
						
					
					
						commit
						5d13c097d3
					
				| @ -23,6 +23,6 @@ public class OrderApiClient : IOrderApiClient | |||||||
| 
 | 
 | ||||||
|         var ordersDraftResponse = await response.Content.ReadAsStringAsync(); |         var ordersDraftResponse = await response.Content.ReadAsStringAsync(); | ||||||
| 
 | 
 | ||||||
|         return JsonSerializer.Deserialize<OrderData>(ordersDraftResponse, JsonHelper.CaseInsensitiveOptions); |         return JsonSerializer.Deserialize<OrderData>(ordersDraftResponse, JsonDefaults.CaseInsensitiveOptions); | ||||||
|     } |     } | ||||||
| } | } | ||||||
|  | |||||||
| @ -23,6 +23,6 @@ public class OrderApiClient : IOrderApiClient | |||||||
| 
 | 
 | ||||||
|         var ordersDraftResponse = await response.Content.ReadAsStringAsync(); |         var ordersDraftResponse = await response.Content.ReadAsStringAsync(); | ||||||
| 
 | 
 | ||||||
|         return JsonSerializer.Deserialize<OrderData>(ordersDraftResponse, JsonHelper.CaseInsensitiveOptions); |         return JsonSerializer.Deserialize<OrderData>(ordersDraftResponse, JsonDefaults.CaseInsensitiveOptions); | ||||||
|     } |     } | ||||||
| } | } | ||||||
|  | |||||||
| @ -35,12 +35,12 @@ public class RedisBasketRepository : IBasketRepository | |||||||
|             return null; |             return null; | ||||||
|         } |         } | ||||||
| 
 | 
 | ||||||
|         return JsonSerializer.Deserialize<CustomerBasket>(data, JsonHelper.CaseInsensitiveOptions); |         return JsonSerializer.Deserialize<CustomerBasket>(data, JsonDefaults.CaseInsensitiveOptions); | ||||||
|     } |     } | ||||||
| 
 | 
 | ||||||
|     public async Task<CustomerBasket> UpdateBasketAsync(CustomerBasket basket) |     public async Task<CustomerBasket> UpdateBasketAsync(CustomerBasket basket) | ||||||
|     { |     { | ||||||
|         var created = await _database.StringSetAsync(basket.BuyerId, JsonSerializer.Serialize(basket, JsonHelper.CaseInsensitiveOptions)); |         var created = await _database.StringSetAsync(basket.BuyerId, JsonSerializer.Serialize(basket, JsonDefaults.CaseInsensitiveOptions)); | ||||||
| 
 | 
 | ||||||
|         if (!created) |         if (!created) | ||||||
|         { |         { | ||||||
|  | |||||||
| @ -2,7 +2,7 @@ | |||||||
| 
 | 
 | ||||||
| namespace Services.Common; | namespace Services.Common; | ||||||
| 
 | 
 | ||||||
| public static class JsonHelper | public static class JsonDefaults | ||||||
| { | { | ||||||
|     public static readonly JsonSerializerOptions CaseInsensitiveOptions = new() |     public static readonly JsonSerializerOptions CaseInsensitiveOptions = new() | ||||||
|     { |     { | ||||||
| @ -29,7 +29,7 @@ public class BasketService : IBasketService | |||||||
|         var responseString = await response.Content.ReadAsStringAsync(); |         var responseString = await response.Content.ReadAsStringAsync(); | ||||||
|         return string.IsNullOrEmpty(responseString) ? |         return string.IsNullOrEmpty(responseString) ? | ||||||
|             new Basket() { BuyerId = user.Id } : |             new Basket() { BuyerId = user.Id } : | ||||||
|             JsonSerializer.Deserialize<Basket>(responseString, JsonHelper.CaseInsensitiveOptions); |             JsonSerializer.Deserialize<Basket>(responseString, JsonDefaults.CaseInsensitiveOptions); | ||||||
|     } |     } | ||||||
| 
 | 
 | ||||||
|     public async Task<Basket> UpdateBasket(Basket basket) |     public async Task<Basket> UpdateBasket(Basket basket) | ||||||
| @ -79,7 +79,7 @@ public class BasketService : IBasketService | |||||||
| 
 | 
 | ||||||
|         var jsonResponse = await response.Content.ReadAsStringAsync(); |         var jsonResponse = await response.Content.ReadAsStringAsync(); | ||||||
| 
 | 
 | ||||||
|         return JsonSerializer.Deserialize<Basket>(jsonResponse, JsonHelper.CaseInsensitiveOptions); |         return JsonSerializer.Deserialize<Basket>(jsonResponse, JsonDefaults.CaseInsensitiveOptions); | ||||||
|     } |     } | ||||||
| 
 | 
 | ||||||
|     public async Task<Order> GetOrderDraft(string basketId) |     public async Task<Order> GetOrderDraft(string basketId) | ||||||
| @ -88,7 +88,7 @@ public class BasketService : IBasketService | |||||||
| 
 | 
 | ||||||
|         var responseString = await _apiClient.GetStringAsync(uri); |         var responseString = await _apiClient.GetStringAsync(uri); | ||||||
| 
 | 
 | ||||||
|         var response = JsonSerializer.Deserialize<Order>(responseString, JsonHelper.CaseInsensitiveOptions); |         var response = JsonSerializer.Deserialize<Order>(responseString, JsonDefaults.CaseInsensitiveOptions); | ||||||
| 
 | 
 | ||||||
|         return response; |         return response; | ||||||
|     } |     } | ||||||
|  | |||||||
| @ -23,7 +23,7 @@ public class CatalogService : ICatalogService | |||||||
| 
 | 
 | ||||||
|         var responseString = await _httpClient.GetStringAsync(uri); |         var responseString = await _httpClient.GetStringAsync(uri); | ||||||
| 
 | 
 | ||||||
|         var catalog = JsonSerializer.Deserialize<Catalog>(responseString, JsonHelper.CaseInsensitiveOptions); |         var catalog = JsonSerializer.Deserialize<Catalog>(responseString, JsonDefaults.CaseInsensitiveOptions); | ||||||
| 
 | 
 | ||||||
|         return catalog; |         return catalog; | ||||||
|     } |     } | ||||||
|  | |||||||
| @ -23,7 +23,7 @@ public class OrderingService : IOrderingService | |||||||
| 
 | 
 | ||||||
|         var responseString = await _httpClient.GetStringAsync(uri); |         var responseString = await _httpClient.GetStringAsync(uri); | ||||||
| 
 | 
 | ||||||
|         var response = JsonSerializer.Deserialize<Order>(responseString, JsonHelper.CaseInsensitiveOptions); |         var response = JsonSerializer.Deserialize<Order>(responseString, JsonDefaults.CaseInsensitiveOptions); | ||||||
| 
 | 
 | ||||||
|         return response; |         return response; | ||||||
|     } |     } | ||||||
| @ -34,7 +34,7 @@ public class OrderingService : IOrderingService | |||||||
| 
 | 
 | ||||||
|         var responseString = await _httpClient.GetStringAsync(uri); |         var responseString = await _httpClient.GetStringAsync(uri); | ||||||
| 
 | 
 | ||||||
|         var response = JsonSerializer.Deserialize<List<Order>>(responseString, JsonHelper.CaseInsensitiveOptions); |         var response = JsonSerializer.Deserialize<List<Order>>(responseString, JsonDefaults.CaseInsensitiveOptions); | ||||||
| 
 | 
 | ||||||
|         return response; |         return response; | ||||||
|     } |     } | ||||||
|  | |||||||
| @ -14,7 +14,7 @@ public class WebhooksClient : IWebhooksClient | |||||||
|         var client = _httpClientFactory.CreateClient("GrantClient"); |         var client = _httpClientFactory.CreateClient("GrantClient"); | ||||||
|         var response = await client.GetAsync(_options.WebhooksUrl + "/api/v1/webhooks"); |         var response = await client.GetAsync(_options.WebhooksUrl + "/api/v1/webhooks"); | ||||||
|         var json = await response.Content.ReadAsStringAsync(); |         var json = await response.Content.ReadAsStringAsync(); | ||||||
|         var subscriptions = JsonSerializer.Deserialize<IEnumerable<WebhookResponse>>(json, JsonHelper.CaseInsensitiveOptions); |         var subscriptions = JsonSerializer.Deserialize<IEnumerable<WebhookResponse>>(json, JsonDefaults.CaseInsensitiveOptions); | ||||||
|         return subscriptions; |         return subscriptions; | ||||||
|     } |     } | ||||||
| } | } | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user