From a0eb95e0017745a417039a1045d4bb2910c1f0d4 Mon Sep 17 00:00:00 2001 From: Alex Kryvdyk Date: Fri, 23 Mar 2018 09:58:05 +0200 Subject: [PATCH] Remove private setters to make class immutable Remove private setters to make Enumeration immutable. Otherwise, it's possible to change the property values. ```csharp public override string ToString() { Name = "Whatever"; return Name; } ``` ## Summary Remove private setters for public properties --- src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs b/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs index ecf248be9..7eae7ab7e 100644 --- a/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs +++ b/src/Services/Ordering/Ordering.Domain/SeedWork/Enumeration.cs @@ -7,9 +7,9 @@ namespace Microsoft.eShopOnContainers.Services.Ordering.Domain.SeedWork { public abstract class Enumeration : IComparable { - public string Name { get; private set; } + public string Name { get; } - public int Id { get; private set; } + public int Id { get; } protected Enumeration() {