From 6eaf3ae452be07861ac55bfc3dd175e0951eb31d Mon Sep 17 00:00:00 2001 From: Cesar De la Torre Date: Thu, 9 Nov 2017 11:38:53 -0800 Subject: [PATCH] Cleaned-up Order class and EventBusRabbitMQ class --- .../EventBus/EventBusRabbitMQ/EventBusRabbitMQ.cs | 3 --- .../Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs | 5 ----- 2 files changed, 8 deletions(-) diff --git a/src/BuildingBlocks/EventBus/EventBusRabbitMQ/EventBusRabbitMQ.cs b/src/BuildingBlocks/EventBus/EventBusRabbitMQ/EventBusRabbitMQ.cs index 2416e1d55..c4714fdae 100644 --- a/src/BuildingBlocks/EventBus/EventBusRabbitMQ/EventBusRabbitMQ.cs +++ b/src/BuildingBlocks/EventBus/EventBusRabbitMQ/EventBusRabbitMQ.cs @@ -147,7 +147,6 @@ namespace Microsoft.eShopOnContainers.BuildingBlocks.EventBusRabbitMQ _subsManager.RemoveDynamicSubscription(eventName); } - public void Dispose() { if (_consumerChannel != null) @@ -196,8 +195,6 @@ namespace Microsoft.eShopOnContainers.BuildingBlocks.EventBusRabbitMQ private async Task ProcessEvent(string eventName, string message) { - - if (_subsManager.HasSubscriptionsForEvent(eventName)) { using (var scope = _autofac.BeginLifetimeScope(AUTOFAC_SCOPE_NAME)) diff --git a/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs b/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs index 661965c5c..cd69aa211 100644 --- a/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs +++ b/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs @@ -30,12 +30,7 @@ namespace Microsoft.eShopOnContainers.Services.Ordering.Domain.AggregatesModel.O // so OrderItems cannot be added from "outside the AggregateRoot" directly to the collection, // but only through the method OrderAggrergateRoot.AddOrderItem() which includes behaviour. private readonly List _orderItems; - public IReadOnlyCollection OrderItems => _orderItems; - // Using List<>.AsReadOnly() - // This will create a read only wrapper around the private list so is protected against "external updates". - // It's much cheaper than .ToList() because it will not have to copy all items in a new collection. (Just one heap alloc for the wrapper instance) - //https://msdn.microsoft.com/en-us/library/e78dcd75(v=vs.110).aspx private int? _paymentMethodId;