From 8d3041363addd8f3e6d7e1169de7d996437b9570 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ram=C3=B3n=20Tom=C3=A1s?= Date: Wed, 24 May 2017 16:46:34 +0200 Subject: [PATCH] Clean commented tests --- .../Services/Ordering/OrderingScenarios.cs | 31 +----------- .../Application/OrderControllerTest.cs | 48 +------------------ 2 files changed, 2 insertions(+), 77 deletions(-) diff --git a/test/Services/FunctionalTests/Services/Ordering/OrderingScenarios.cs b/test/Services/FunctionalTests/Services/Ordering/OrderingScenarios.cs index 50ae3cdbb..57d107033 100644 --- a/test/Services/FunctionalTests/Services/Ordering/OrderingScenarios.cs +++ b/test/Services/FunctionalTests/Services/Ordering/OrderingScenarios.cs @@ -15,36 +15,7 @@ using Xunit; namespace FunctionalTests.Services.Ordering { public class OrderingScenarios : OrderingScenariosBase - { - // Issue: Unable to communicate with test host process - //[Fact] - //public async Task Checkout_basket_and_check_order_status_submitted() - //{ - // using (var orderServer = new OrderingScenariosBase().CreateServer()) - // using (var basketServer = new BasketScenariosBase().CreateServer()) - // { - // // Expected data - // var cityExpected = $"city-{Guid.NewGuid()}"; - // var orderStatusExpected = "submitted"; - - // var basketClient = basketServer.CreateIdempotentClient(); - // var orderClient = orderServer.CreateIdempotentClient(); - - // // GIVEN a basket is created - // var contentBasket = new StringContent(BuildBasket(), UTF8Encoding.UTF8, "application/json"); - // await basketClient.PostAsync(BasketScenariosBase.Post.CreateBasket, contentBasket); - - // // AND basket checkout is sent - // await basketClient.PostAsync(BasketScenariosBase.Post.Checkout, new StringContent(BuildCheckout(cityExpected), UTF8Encoding.UTF8, "application/json")); - - // // AND the requested order is retrieved - // var newOrder = await TryGetNewOrderCreated(cityExpected, orderClient); - - // // THEN check status - // Assert.Equal(orderStatusExpected, newOrder.Status); - // } - //} - + { [Fact] public async Task Cancel_basket_and_check_order_status_cancelled() { diff --git a/test/Services/UnitTest/Ordering/Application/OrderControllerTest.cs b/test/Services/UnitTest/Ordering/Application/OrderControllerTest.cs index 66c42906f..12f2be395 100644 --- a/test/Services/UnitTest/Ordering/Application/OrderControllerTest.cs +++ b/test/Services/UnitTest/Ordering/Application/OrderControllerTest.cs @@ -93,53 +93,7 @@ namespace UnitTest.Ordering.Application //Assert var viewResult = Assert.IsType(actionResult); Assert.IsAssignableFrom(viewResult.ViewData.Model); - } - - //[Fact] - //public async Task Post_create_order_success() - //{ - // //Arrange - // var fakeOrder = GetFakeOrder(); - - // _basketServiceMock.Setup(x => x.CleanBasket(It.IsAny())) - // .Returns(Task.FromResult(1)); - - // _orderServiceMock.Setup(x => x.CreateOrder(It.IsAny())) - // .Returns(Task.FromResult(1)); - - // //Act - // var orderController = new OrderController(_orderServiceMock.Object, _basketServiceMock.Object, _identityParserMock.Object); - // orderController.ControllerContext.HttpContext = _contextMock.Object; - // var actionResult = await orderController.Create(fakeOrder, "fakeAction"); - - // //Assert - // var redirectToActionResult = Assert.IsType(actionResult); - // Assert.Null(redirectToActionResult.ControllerName); - // Assert.Equal("Index", redirectToActionResult.ActionName); - //} - - //[Fact] - //public async Task Post_create_order_fail() - //{ - // //Arrange - // var fakeOrder = GetFakeOrder(); - - // _basketServiceMock.Setup(x => x.CleanBasket(It.IsAny())) - // .Returns(Task.FromResult(1)); - - // _orderServiceMock.Setup(x => x.CreateOrder(It.IsAny())) - // .Returns(Task.FromResult(1)); - - // //Act - // var orderController = new OrderController(_orderServiceMock.Object, _basketServiceMock.Object, _identityParserMock.Object); - // orderController.ControllerContext.HttpContext = _contextMock.Object; - // orderController.ModelState.AddModelError("fakeError", "fakeError"); - // var actionResult = await orderController.Create(fakeOrder, "action"); - - // //Assert - // var viewResult = Assert.IsType(actionResult); - // Assert.IsAssignableFrom(viewResult.ViewData.Model); - //} + } private BasketModel GetFakeBasket(string buyerId) {