diff --git a/src/Services/Basket/Basket.API/Controllers/BasketController.cs b/src/Services/Basket/Basket.API/Controllers/BasketController.cs index 548eb2bbf..2cb3fcafe 100644 --- a/src/Services/Basket/Basket.API/Controllers/BasketController.cs +++ b/src/Services/Basket/Basket.API/Controllers/BasketController.cs @@ -9,7 +9,7 @@ using Microsoft.AspNetCore.Authorization; namespace Microsoft.eShopOnContainers.Services.Basket.API.Controllers { //TODO NOTE: Right now this is a very chunky API, as the app evolves it is possible we would - //want to make the actions more fine graned, add basket item as an action for example. + //want to make the actions more fine grained, add basket item as an action for example. //If this is the case we should also investigate changing the serialization format used for Redis, //using a HashSet instead of a simple string. [Route("/")] diff --git a/src/Services/Catalog/Catalog.API/README.md b/src/Services/Catalog/Catalog.API/README.md index 5616bab52..681da9965 100644 --- a/src/Services/Catalog/Catalog.API/README.md +++ b/src/Services/Catalog/Catalog.API/README.md @@ -3,12 +3,12 @@ Sample reference containerized application, cross-platform and microservices arc Powered by Microsoft #Overview -This sample runs a microservices oriented application and a .net core Mvc application that consumes this services. You can find more information about how to set up docker in your machine in the global directory solution. +This sample runs a microservices oriented application and an ASP.NET Core MVC application that consumes these services. You can find more information about how to set up docker in your machine in the global directory solution. #Deploy -In the global directory you will find the scripts needed to run and deploy the demo into your local docker infraestructure. +In the global directory you will find the scripts needed to run and deploy the demo into your local docker infrastructure. -- build-image-services-catalog.ps1 Build .net applications and docker images: This power shell script that you will find in the root directory of the solution is the responsible of building .net applications and package in a pub folder and use docker commands to build the images needed to run the previously packaged .net applications. +- build-image-services-catalog.ps1 Build .net applications and docker images: This PowerShell script that you will find in the root directory of the solution is responsible for building .NET applications and package in a pub folder and use docker commands to build the images needed to run the previously packaged .NET applications. - Compose containers in your docker local VM: Finally you have to open your favourite command tool pointing to the root directory of this project where docker-compose.yml file is located and run the command `docker-compose up` diff --git a/src/Services/Catalog/Catalog.API/settings.cs b/src/Services/Catalog/Catalog.API/settings.cs index e73359302..76091c409 100644 --- a/src/Services/Catalog/Catalog.API/settings.cs +++ b/src/Services/Catalog/Catalog.API/settings.cs @@ -5,6 +5,7 @@ using System.Threading.Tasks; namespace Microsoft.eShopOnContainers.Services.Catalog.API { + // TODO: Rename CatalogSettings for consistency? public class Settings { public string ExternalCatalogBaseUrl {get;set;}