Merge pull request #16 from dotnet-architecture/dev

upd fork

docker-compose-external.override.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 services:
   sql.data:

docker-compose-external.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 services:
   sql.data:

docker-compose-windows.prod.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 # The Production docker-compose file has to have the external/real IPs or DNS names for the services 
 # The ESHOP_PROD_EXTERNAL_DNS_NAME_OR_IP environment variable is taken, by default, from the ".env" file defined like: 

docker-compose-windows.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 services:
   basket.api:

docker-compose.ci.build.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 services:
   ci-build:
@@ -8,6 +8,7 @@ services:
       - ./cli-linux:/cli-linux
     working_dir: /src
 
+
 #   Next line is using the .sln file to compile all the projects. 
 #   Sometime there is an issue in msbuild exits the process before finishing building the bits: (https://github.com/Microsoft/msbuild/issues/2153)
 #   Random error: error MSB4017: The build stopped unexpectedly be cause of an unexpected logger failure.

docker-compose.nobuild.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 services:
   basket.api:

docker-compose.override.windows.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 # ONLY NEEDED WHEN RUNNING WINDOWS CONTAINERS
 #

docker-compose.override.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 # The default docker-compose.override file can use the "localhost" as the external name for testing web apps within the same dev machine. 
 # The ESHOP_EXTERNAL_DNS_NAME_OR_IP environment variable is taken, by default, from the ".env" file defined like: 
@@ -203,7 +203,7 @@ services:
 
   sql.data:
     environment:
-      - sa_password=Pass@word
+      - SA_PASSWORD=Pass@word
       - ACCEPT_EULA=Y
     ports:
       - "5433:1433"

docker-compose.prod.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 # The Production docker-compose file has to have the external/real IPs or DNS names for the services 
 # The ESHOP_PROD_EXTERNAL_DNS_NAME_OR_IP environment variable is taken, by default, from the ".env" file defined like: 

docker-compose.yml

@@ -1,4 +1,4 @@
-version: '3.4'
+version: '3.3'
 
 services: