From c203f9cdcfb3b4e1f83aeb470a93bce9c5197a55 Mon Sep 17 00:00:00 2001
From: Marusyk <romamarusyk@gmail.com>
Date: Thu, 29 Mar 2018 18:08:32 +0300
Subject: [PATCH] Marketing and Payment. Fixed async/await misuses

---
 .../Marketing.API/Infrastructure/MarketingContextSeed.cs  | 4 ++--
 .../Repositories/MarketingDataRepository.cs               | 8 ++++----
 ...tatusChangedToStockConfirmedIntegrationEventHandler.cs | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/Services/Marketing/Marketing.API/Infrastructure/MarketingContextSeed.cs b/src/Services/Marketing/Marketing.API/Infrastructure/MarketingContextSeed.cs
index c42b1975e..526f759f8 100644
--- a/src/Services/Marketing/Marketing.API/Infrastructure/MarketingContextSeed.cs
+++ b/src/Services/Marketing/Marketing.API/Infrastructure/MarketingContextSeed.cs
@@ -11,11 +11,11 @@
 
     public class MarketingContextSeed
     {
-        public async Task SeedAsync(MarketingContext context,ILogger<MarketingContextSeed> logger,int retries = 3)
+        public Task SeedAsync(MarketingContext context,ILogger<MarketingContextSeed> logger,int retries = 3)
         {
             var policy = CreatePolicy(retries, logger, nameof(MarketingContextSeed));
 
-            await policy.ExecuteAsync(async () =>
+            return policy.ExecuteAsync(async () =>
             {
                 if (!context.Campaigns.Any())
                 {
diff --git a/src/Services/Marketing/Marketing.API/Infrastructure/Repositories/MarketingDataRepository.cs b/src/Services/Marketing/Marketing.API/Infrastructure/Repositories/MarketingDataRepository.cs
index 4e531a84c..bbcbb340e 100644
--- a/src/Services/Marketing/Marketing.API/Infrastructure/Repositories/MarketingDataRepository.cs
+++ b/src/Services/Marketing/Marketing.API/Infrastructure/Repositories/MarketingDataRepository.cs
@@ -15,22 +15,22 @@ namespace Microsoft.eShopOnContainers.Services.Marketing.API.Infrastructure.Repo
             _context = new MarketingReadDataContext(settings);
         }
 
-        public async Task<MarketingData> GetAsync(string userId)
+        public Task<MarketingData> GetAsync(string userId)
         {
             var filter = Builders<MarketingData>.Filter.Eq("UserId", userId);
-            return await _context.MarketingData
+            return _context.MarketingData
                                  .Find(filter)
                                  .FirstOrDefaultAsync();
         }
 
-        public async Task UpdateLocationAsync(MarketingData marketingData)
+        public Task UpdateLocationAsync(MarketingData marketingData)
         {
             var filter = Builders<MarketingData>.Filter.Eq("UserId", marketingData.UserId);
             var update = Builders<MarketingData>.Update
                 .Set("Locations", marketingData.Locations)
                 .CurrentDate("UpdateDate");
 
-            await _context.MarketingData
+            return _context.MarketingData
                 .UpdateOneAsync(filter, update, new UpdateOptions { IsUpsert = true });
         }
     }
diff --git a/src/Services/Payment/Payment.API/IntegrationEvents/EventHandling/OrderStatusChangedToStockConfirmedIntegrationEventHandler.cs b/src/Services/Payment/Payment.API/IntegrationEvents/EventHandling/OrderStatusChangedToStockConfirmedIntegrationEventHandler.cs
index c70a32093..88e1ec046 100644
--- a/src/Services/Payment/Payment.API/IntegrationEvents/EventHandling/OrderStatusChangedToStockConfirmedIntegrationEventHandler.cs
+++ b/src/Services/Payment/Payment.API/IntegrationEvents/EventHandling/OrderStatusChangedToStockConfirmedIntegrationEventHandler.cs
@@ -19,7 +19,7 @@
             _settings = settings.Value;
         }         
 
-        public async Task Handle(OrderStatusChangedToStockConfirmedIntegrationEvent @event)
+        public Task Handle(OrderStatusChangedToStockConfirmedIntegrationEvent @event)
         {
             IntegrationEvent orderPaymentIntegrationEvent;
 
@@ -40,7 +40,7 @@
 
             _eventBus.Publish(orderPaymentIntegrationEvent);
 
-            await Task.CompletedTask;
+            return Task.CompletedTask;
         }
     }
 }
\ No newline at end of file