Browse Source

minor refactoring on reviews

pull/49/merge
unai 8 years ago
parent
commit
cbd5682ea0
6 changed files with 7 additions and 18 deletions
  1. +0
    -2
      src/Services/Ordering/Ordering.API/Controllers/OrdersController.cs
  2. +0
    -5
      src/Services/Ordering/Ordering.API/Startup.cs
  3. +7
    -4
      src/Services/Ordering/Ordering.Application/Commands/NewOrderREquestHandler.cs
  4. +0
    -4
      src/Services/Ordering/Ordering.Application/Commands/NewOrderRequest.cs
  5. +0
    -1
      src/Services/Ordering/Ordering.Application/Queries/OrderQueries.cs
  6. +0
    -2
      test/Services/FunctionalTests/Services/Ordering/OrderingScenarios.cs

+ 0
- 2
src/Services/Ordering/Ordering.API/Controllers/OrdersController.cs View File

@ -64,7 +64,6 @@
{
var order = await _orderQueries.GetOrder(orderId);
return Ok(order);
}
@ -74,7 +73,6 @@
{
var orders = await _orderQueries.GetOrders();
return Ok(orders);
}


+ 0
- 5
src/Services/Ordering/Ordering.API/Startup.cs View File

@ -43,9 +43,7 @@
services.AddMvc(options=>
{
options.Filters.Add(typeof(HttpGlobalExceptionFilter));
}).AddControllersAsServices();
services.AddEntityFrameworkSqlServer()
@ -72,8 +70,6 @@
services.AddOptions();
//configure autofac
var container = new ContainerBuilder();
@ -82,7 +78,6 @@
container.RegisterModule(new MediatorModule());
container.RegisterModule(new ApplicationModule());
return new AutofacServiceProvider(container.Build());
}


+ 7
- 4
src/Services/Ordering/Ordering.Application/Commands/NewOrderREquestHandler.cs View File

@ -30,7 +30,7 @@
}
public async Task<bool> Handle(NewOrderRequest message)
{
//find buyer/payment or add a new one
//find buyer/payment or add a new one buyer/payment
var buyer = await _buyerRepository.FindAsync(message.Buyer);
@ -41,9 +41,11 @@
var payment = GetExistingPaymentOrAddANewOne(buyer, message);
await _buyerRepository.UnitOfWork.SaveChangesAsync();
await _buyerRepository.UnitOfWork
.SaveChangesAsync();
//create order for buyer and payment method
//create order
var order = CreateOrder(buyer.Id, payment.Id, 0);
order.SetAddress( new Address()
{
@ -55,7 +57,8 @@
_orderRepository.Add(order);
var result = await _orderRepository.UnitOfWork.SaveChangesAsync();
var result = await _orderRepository.UnitOfWork
.SaveChangesAsync();
return result > 0;
}


+ 0
- 4
src/Services/Ordering/Ordering.Application/Commands/NewOrderRequest.cs View File

@ -27,9 +27,5 @@
public int CardTypeId { get; set; }
public string Buyer { get; set; }
public NewOrderRequest()
{
}
}
}

+ 0
- 1
src/Services/Ordering/Ordering.Application/Queries/OrderQueries.cs View File

@ -50,6 +50,5 @@
return await connection.QueryAsync<dynamic>("SELECT * FROM ordering.cardtypes");
}
}
}
}

+ 0
- 2
test/Services/FunctionalTests/Services/Ordering/OrderingScenarios.cs View File

@ -1,8 +1,6 @@
namespace FunctionalTests.Services.Ordering
{
using Microsoft.AspNetCore.TestHost;
using Microsoft.eShopOnContainers.Services.Ordering.API.Models;
using Microsoft.eShopOnContainers.Services.Ordering.Domain;
using Newtonsoft.Json;
using System;
using System.Net.Http;


Loading…
Cancel
Save