minor refactoring on reviews

This commit is contained in:
unai 2016-12-07 18:59:41 +01:00
parent 923903ce13
commit cbd5682ea0
6 changed files with 7 additions and 18 deletions

View File

@ -64,7 +64,6 @@
{ {
var order = await _orderQueries.GetOrder(orderId); var order = await _orderQueries.GetOrder(orderId);
return Ok(order); return Ok(order);
} }
@ -74,7 +73,6 @@
{ {
var orders = await _orderQueries.GetOrders(); var orders = await _orderQueries.GetOrders();
return Ok(orders); return Ok(orders);
} }

View File

@ -43,9 +43,7 @@
services.AddMvc(options=> services.AddMvc(options=>
{ {
options.Filters.Add(typeof(HttpGlobalExceptionFilter)); options.Filters.Add(typeof(HttpGlobalExceptionFilter));
}).AddControllersAsServices(); }).AddControllersAsServices();
services.AddEntityFrameworkSqlServer() services.AddEntityFrameworkSqlServer()
@ -72,8 +70,6 @@
services.AddOptions(); services.AddOptions();
//configure autofac //configure autofac
var container = new ContainerBuilder(); var container = new ContainerBuilder();
@ -82,7 +78,6 @@
container.RegisterModule(new MediatorModule()); container.RegisterModule(new MediatorModule());
container.RegisterModule(new ApplicationModule()); container.RegisterModule(new ApplicationModule());
return new AutofacServiceProvider(container.Build()); return new AutofacServiceProvider(container.Build());
} }

View File

@ -30,7 +30,7 @@
} }
public async Task<bool> Handle(NewOrderRequest message) public async Task<bool> Handle(NewOrderRequest message)
{ {
//find buyer/payment or add a new one //find buyer/payment or add a new one buyer/payment
var buyer = await _buyerRepository.FindAsync(message.Buyer); var buyer = await _buyerRepository.FindAsync(message.Buyer);
@ -41,9 +41,11 @@
var payment = GetExistingPaymentOrAddANewOne(buyer, message); var payment = GetExistingPaymentOrAddANewOne(buyer, message);
await _buyerRepository.UnitOfWork.SaveChangesAsync(); await _buyerRepository.UnitOfWork
.SaveChangesAsync();
//create order for buyer and payment method
//create order
var order = CreateOrder(buyer.Id, payment.Id, 0); var order = CreateOrder(buyer.Id, payment.Id, 0);
order.SetAddress( new Address() order.SetAddress( new Address()
{ {
@ -55,7 +57,8 @@
_orderRepository.Add(order); _orderRepository.Add(order);
var result = await _orderRepository.UnitOfWork.SaveChangesAsync(); var result = await _orderRepository.UnitOfWork
.SaveChangesAsync();
return result > 0; return result > 0;
} }

View File

@ -27,9 +27,5 @@
public int CardTypeId { get; set; } public int CardTypeId { get; set; }
public string Buyer { get; set; } public string Buyer { get; set; }
public NewOrderRequest()
{
}
} }
} }

View File

@ -50,6 +50,5 @@
return await connection.QueryAsync<dynamic>("SELECT * FROM ordering.cardtypes"); return await connection.QueryAsync<dynamic>("SELECT * FROM ordering.cardtypes");
} }
} }
} }
} }

View File

@ -1,8 +1,6 @@
namespace FunctionalTests.Services.Ordering namespace FunctionalTests.Services.Ordering
{ {
using Microsoft.AspNetCore.TestHost;
using Microsoft.eShopOnContainers.Services.Ordering.API.Models; using Microsoft.eShopOnContainers.Services.Ordering.API.Models;
using Microsoft.eShopOnContainers.Services.Ordering.Domain;
using Newtonsoft.Json; using Newtonsoft.Json;
using System; using System;
using System.Net.Http; using System.Net.Http;