minor refactoring on reviews
This commit is contained in:
parent
923903ce13
commit
cbd5682ea0
@ -64,7 +64,6 @@
|
||||
{
|
||||
var order = await _orderQueries.GetOrder(orderId);
|
||||
|
||||
|
||||
return Ok(order);
|
||||
}
|
||||
|
||||
@ -74,7 +73,6 @@
|
||||
{
|
||||
var orders = await _orderQueries.GetOrders();
|
||||
|
||||
|
||||
return Ok(orders);
|
||||
}
|
||||
|
||||
|
@ -43,9 +43,7 @@
|
||||
|
||||
services.AddMvc(options=>
|
||||
{
|
||||
|
||||
options.Filters.Add(typeof(HttpGlobalExceptionFilter));
|
||||
|
||||
}).AddControllersAsServices();
|
||||
|
||||
services.AddEntityFrameworkSqlServer()
|
||||
@ -72,8 +70,6 @@
|
||||
|
||||
services.AddOptions();
|
||||
|
||||
|
||||
|
||||
//configure autofac
|
||||
|
||||
var container = new ContainerBuilder();
|
||||
@ -82,7 +78,6 @@
|
||||
container.RegisterModule(new MediatorModule());
|
||||
container.RegisterModule(new ApplicationModule());
|
||||
|
||||
|
||||
return new AutofacServiceProvider(container.Build());
|
||||
}
|
||||
|
||||
|
@ -30,7 +30,7 @@
|
||||
}
|
||||
public async Task<bool> Handle(NewOrderRequest message)
|
||||
{
|
||||
//find buyer/payment or add a new one
|
||||
//find buyer/payment or add a new one buyer/payment
|
||||
|
||||
var buyer = await _buyerRepository.FindAsync(message.Buyer);
|
||||
|
||||
@ -41,9 +41,11 @@
|
||||
|
||||
var payment = GetExistingPaymentOrAddANewOne(buyer, message);
|
||||
|
||||
await _buyerRepository.UnitOfWork.SaveChangesAsync();
|
||||
await _buyerRepository.UnitOfWork
|
||||
.SaveChangesAsync();
|
||||
|
||||
//create order for buyer and payment method
|
||||
|
||||
//create order
|
||||
var order = CreateOrder(buyer.Id, payment.Id, 0);
|
||||
order.SetAddress( new Address()
|
||||
{
|
||||
@ -55,7 +57,8 @@
|
||||
|
||||
_orderRepository.Add(order);
|
||||
|
||||
var result = await _orderRepository.UnitOfWork.SaveChangesAsync();
|
||||
var result = await _orderRepository.UnitOfWork
|
||||
.SaveChangesAsync();
|
||||
|
||||
return result > 0;
|
||||
}
|
||||
|
@ -27,9 +27,5 @@
|
||||
public int CardTypeId { get; set; }
|
||||
|
||||
public string Buyer { get; set; }
|
||||
|
||||
public NewOrderRequest()
|
||||
{
|
||||
}
|
||||
}
|
||||
}
|
||||
|
@ -50,6 +50,5 @@
|
||||
return await connection.QueryAsync<dynamic>("SELECT * FROM ordering.cardtypes");
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
|
@ -1,8 +1,6 @@
|
||||
namespace FunctionalTests.Services.Ordering
|
||||
{
|
||||
using Microsoft.AspNetCore.TestHost;
|
||||
using Microsoft.eShopOnContainers.Services.Ordering.API.Models;
|
||||
using Microsoft.eShopOnContainers.Services.Ordering.Domain;
|
||||
using Newtonsoft.Json;
|
||||
using System;
|
||||
using System.Net.Http;
|
||||
|
Loading…
x
Reference in New Issue
Block a user