From d1f711e85f835c661136f29cefbda5d1061160de Mon Sep 17 00:00:00 2001 From: Sumit Ghosh Date: Wed, 1 Sep 2021 14:33:15 +0530 Subject: [PATCH] Apply suggestions from code review Co-authored-by: David Pine --- .../Server/AuthorizationHeaderParameterOperationFilter.cs | 3 +-- .../Exceptions/FailingMiddlewareAppBuilderExtensions.cs | 1 + .../Infrastructure/Repositories/RedisBasketRepository.cs | 3 ++- .../IntegrationEvents/Events/OrderStartedIntegrationEvent.cs | 2 +- .../Events/ProductPriceChangedIntegrationEvent.cs | 2 +- src/Services/Basket/Basket.API/Model/BasketCheckout.cs | 3 ++- src/Services/Basket/Basket.API/Model/BasketItem.cs | 1 + src/Services/Basket/Basket.API/Model/CustomerBasket.cs | 5 +++-- 8 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/Services/Basket/Basket.API/Auth/Server/AuthorizationHeaderParameterOperationFilter.cs b/src/Services/Basket/Basket.API/Auth/Server/AuthorizationHeaderParameterOperationFilter.cs index d8e0fecb3..2acda7be8 100644 --- a/src/Services/Basket/Basket.API/Auth/Server/AuthorizationHeaderParameterOperationFilter.cs +++ b/src/Services/Basket/Basket.API/Auth/Server/AuthorizationHeaderParameterOperationFilter.cs @@ -10,8 +10,7 @@ public class AuthorizationHeaderParameterOperationFilter : IOperationFilter if (isAuthorized && !allowAnonymous) { - if (operation.Parameters == null) - operation.Parameters = new List(); + operation.Parameters ??= new List(); operation.Parameters.Add(new OpenApiParameter diff --git a/src/Services/Basket/Basket.API/Infrastructure/Exceptions/FailingMiddlewareAppBuilderExtensions.cs b/src/Services/Basket/Basket.API/Infrastructure/Exceptions/FailingMiddlewareAppBuilderExtensions.cs index f60c6035a..66f55dddd 100644 --- a/src/Services/Basket/Basket.API/Infrastructure/Exceptions/FailingMiddlewareAppBuilderExtensions.cs +++ b/src/Services/Basket/Basket.API/Infrastructure/Exceptions/FailingMiddlewareAppBuilderExtensions.cs @@ -6,6 +6,7 @@ public static class FailingMiddlewareAppBuilderExtensions { return UseFailingMiddleware(builder, null); } + public static IApplicationBuilder UseFailingMiddleware(this IApplicationBuilder builder, Action action) { var options = new FailingOptions(); diff --git a/src/Services/Basket/Basket.API/Infrastructure/Repositories/RedisBasketRepository.cs b/src/Services/Basket/Basket.API/Infrastructure/Repositories/RedisBasketRepository.cs index d04d794b1..7db463f20 100644 --- a/src/Services/Basket/Basket.API/Infrastructure/Repositories/RedisBasketRepository.cs +++ b/src/Services/Basket/Basket.API/Infrastructure/Repositories/RedisBasketRepository.cs @@ -1,4 +1,5 @@ -namespace Microsoft.eShopOnContainers.Services.Basket.API.Infrastructure.Repositories; +namespace Microsoft.eShopOnContainers.Services.Basket.API.Infrastructure.Repositories; + public class RedisBasketRepository : IBasketRepository { private readonly ILogger _logger; diff --git a/src/Services/Basket/Basket.API/IntegrationEvents/Events/OrderStartedIntegrationEvent.cs b/src/Services/Basket/Basket.API/IntegrationEvents/Events/OrderStartedIntegrationEvent.cs index 2f786fecf..06954890e 100644 --- a/src/Services/Basket/Basket.API/IntegrationEvents/Events/OrderStartedIntegrationEvent.cs +++ b/src/Services/Basket/Basket.API/IntegrationEvents/Events/OrderStartedIntegrationEvent.cs @@ -1,7 +1,7 @@ namespace Basket.API.IntegrationEvents.Events; // Integration Events notes: -// An Event is “something that has happened in the past”, therefore its name has to be +// An Event is "something that has happened in the past", therefore its name has to be // An Integration Event is an event that can cause side effects to other microsrvices, Bounded-Contexts or external systems. public record OrderStartedIntegrationEvent : IntegrationEvent { diff --git a/src/Services/Basket/Basket.API/IntegrationEvents/Events/ProductPriceChangedIntegrationEvent.cs b/src/Services/Basket/Basket.API/IntegrationEvents/Events/ProductPriceChangedIntegrationEvent.cs index ab79e6534..b0f87f58a 100644 --- a/src/Services/Basket/Basket.API/IntegrationEvents/Events/ProductPriceChangedIntegrationEvent.cs +++ b/src/Services/Basket/Basket.API/IntegrationEvents/Events/ProductPriceChangedIntegrationEvent.cs @@ -1,7 +1,7 @@ namespace Microsoft.eShopOnContainers.Services.Basket.API.IntegrationEvents.Events; // Integration Events notes: -// An Event is “something that has happened in the past”, therefore its name has to be +// An Event is "something that has happened in the past", therefore its name has to be // An Integration Event is an event that can cause side effects to other microsrvices, Bounded-Contexts or external systems. public record ProductPriceChangedIntegrationEvent : IntegrationEvent { diff --git a/src/Services/Basket/Basket.API/Model/BasketCheckout.cs b/src/Services/Basket/Basket.API/Model/BasketCheckout.cs index 358e3a192..5340444d7 100644 --- a/src/Services/Basket/Basket.API/Model/BasketCheckout.cs +++ b/src/Services/Basket/Basket.API/Model/BasketCheckout.cs @@ -1,4 +1,5 @@ -namespace Basket.API.Model; +namespace Basket.API.Model; + public class BasketCheckout { public string City { get; set; } diff --git a/src/Services/Basket/Basket.API/Model/BasketItem.cs b/src/Services/Basket/Basket.API/Model/BasketItem.cs index e2b594ac9..85ebdb9a4 100644 --- a/src/Services/Basket/Basket.API/Model/BasketItem.cs +++ b/src/Services/Basket/Basket.API/Model/BasketItem.cs @@ -9,6 +9,7 @@ public class BasketItem : IValidatableObject public decimal OldUnitPrice { get; set; } public int Quantity { get; set; } public string PictureUrl { get; set; } + public IEnumerable Validate(ValidationContext validationContext) { var results = new List(); diff --git a/src/Services/Basket/Basket.API/Model/CustomerBasket.cs b/src/Services/Basket/Basket.API/Model/CustomerBasket.cs index 37b975f7b..2ca370be8 100644 --- a/src/Services/Basket/Basket.API/Model/CustomerBasket.cs +++ b/src/Services/Basket/Basket.API/Model/CustomerBasket.cs @@ -1,9 +1,10 @@ -namespace Microsoft.eShopOnContainers.Services.Basket.API.Model; +namespace Microsoft.eShopOnContainers.Services.Basket.API.Model; + public class CustomerBasket { public string BuyerId { get; set; } - public List Items { get; set; } = new List(); + public List Items { get; set; } = new(); public CustomerBasket() {