From f1c0db111811e8cd892a92c599f913c0a629057c Mon Sep 17 00:00:00 2001 From: Sumit Ghosh Date: Thu, 21 Oct 2021 14:21:19 +0530 Subject: [PATCH] Fixed bugs in Mobile.BFF.Shopping project --- .../aggregator/Controllers/BasketController.cs | 6 +++--- .../aggregator/Controllers/OrderController.cs | 2 +- .../aggregator/Services/BasketService.cs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/BasketController.cs b/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/BasketController.cs index 9f39cdd6d..2ce40d737 100644 --- a/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/BasketController.cs +++ b/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/BasketController.cs @@ -26,7 +26,7 @@ public class BasketController : ControllerBase } // Retrieve the current basket - var basket = await _basket.GetById(data.BuyerId) ?? new BasketData(data.BuyerId); + var basket = await _basket.GetByIdAsync(data.BuyerId) ?? new BasketData(data.BuyerId); var catalogItems = await _catalog.GetCatalogItemsAsync(data.Items.Select(x => x.ProductId)); // group by product id to avoid duplicates @@ -84,7 +84,7 @@ public class BasketController : ControllerBase } // Retrieve the current basket - var currentBasket = await _basket.GetById(data.BasketId); + var currentBasket = await _basket.GetByIdAsync(data.BasketId); if (currentBasket == null) { return BadRequest($"Basket with id {data.BasketId} not found."); @@ -126,7 +126,7 @@ public class BasketController : ControllerBase //item.PictureUri = // Step 2: Get current basket status - var currentBasket = (await _basket.GetById(data.BasketId)) ?? new BasketData(data.BasketId); + var currentBasket = (await _basket.GetByIdAsync(data.BasketId)) ?? new BasketData(data.BasketId); // Step 3: Merge current status with new product currentBasket.Items.Add(new BasketDataItem() { diff --git a/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/OrderController.cs b/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/OrderController.cs index 2203db664..55b4dd70b 100644 --- a/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/OrderController.cs +++ b/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Controllers/OrderController.cs @@ -25,7 +25,7 @@ public class OrderController : ControllerBase return BadRequest("Need a valid basketid"); } // Get the basket data and build a order draft based on it - var basket = await _basketService.GetById(basketId); + var basket = await _basketService.GetByIdAsync(basketId); if (basket == null) { diff --git a/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Services/BasketService.cs b/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Services/BasketService.cs index 1b081bf85..b9fed393f 100644 --- a/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Services/BasketService.cs +++ b/src/ApiGateways/Mobile.Bff.Shopping/aggregator/Services/BasketService.cs @@ -11,7 +11,7 @@ public class BasketService : IBasketService _logger = logger; } - public async Task GetById(string id) + public async Task GetByIdAsync(string id) { _logger.LogDebug("grpc client created, request = {@id}", id); var response = await _basketClient.GetBasketByIdAsync(new BasketRequest { Id = id });