16 Commits

Author SHA1 Message Date
Viswanatha Swamy
811874b76a
Swamy/remove unused using and refactor the code (#1555)
* Removed Unused Using and Reorganized the Using

* Removed unused using, Reorganized using, moved the class to separate file, removed commented code in Catalog.API

* Revert "Removed unused using, Reorganized using, moved the class to separate file, removed commented code in Catalog.API"

This reverts commit 34241c430619b3b0bbeaabafa44c078c859237c4.

* Removed unused using and reorganized the using inside "Services" folder

* Removed Unused using and reoganized the using

* Refactor Webhooks.API

* Removed unused using and reorganized using inside Catalog.API

* Refactoring

* Removed unsed using

* Added line break just to differentiate between the messages

* Removed unused usings

* Simple Refactoring
2020-12-23 15:19:36 +05:30
eiximenis
08e9b2641a Final adjustments to make envoy work with ingress and remove Polly from http calls 2019-10-01 19:30:09 +02:00
Ramón Tomás
4dff728d11 Replaced custom DataProtection.Redis lib with official Microsoft pkg
Removed Sessions in WebMVC app
Fixed GracePeriodMgr issues using multiple instances
2017-11-30 11:40:30 +01:00
Ramón Tomás
d42033a83b Added UI alert and circuit-breaker handlers for components that depend on Basket.api 2017-07-14 14:53:17 +02:00
Ramón Tomás
f39fdb92ca Fix Failing middleware and move it to Basket.api 2017-07-13 17:35:19 +02:00
RamonTC
ec71fbb5ae Remove async await issue comments 2017-03-21 12:52:59 +01:00
Bill Wagner
00491910a2 C# 7 language feature updates
Controllers/AccountController:
Replace single line methods with expression bodied members.
Includes constructor, C# 7 feature.

Controllers/CatalogController:
Remove unnecessary ToString() call.
Replace single line methods with expression bodied members.

Extensions/HttpClientExtensions:
Replace single line methods with expression bodied members.

Extensions/SessionExtensions:
Replace single line methods with expression bodied members.

Services/BasketService:
Remove unnecessary ToString() calls.
Add ?? to simplify conditional initialization
Use TryGetValue and out variable initialization to simplify Quantity
calculation

Services/CatalogService:
Use Value<T> generic method instead of dynamic types.
There is a lot of overhead for dynamic and it seems overkill here.

Services/IdentityParser:
Use the pattern matching is expression.
Refactor the LINQ queries to enumerate the collection (and create an
enumerator)
only once. The previous code had 3 enumerations.

Services/Utilities/HttpApiClient:
Remove the 'async' modifier and 'await' statements from methods where
the only asynchronous statement is the final statement of the method,
and
the task from the underlying method can be returned.

Services/Utilities/HttpApiClientWrapper:
Use expression bodied members where applicable.
Remove the 'async' modifier and 'await' statements from methods where
the only asynchronous statement is the final statement of the method,
and
the task from the underlying method can be returned.

ViewComponents/Cart:
Use expression bodied members where applicable.

ViewComponents/CartList:
Use expression bodied members where applicable.
Remove the 'async' modifier and 'await' statements from methods where
the only asynchronous statement is the final statement of the method,
and
the task from the underlying method can be returned.

ViewModels/Annotations/CardExpiration:
Use the out variable initializer to simplify the validation of the
card expiration date.

ViewModels/Basket:
Use property initializer syntax instead of constructor body

ViewModels/CatalogViewModels/IndexViewModel:
Use expression bodied property to return the calculated 'Disabled'
property

ViewModels/Order:
Use property initializer syntax.
2017-03-20 14:18:20 -04:00
dsanz
a1f2cc9975 Fix for issue #67 https://github.com/dotnet/eShopOnContainers/issues/67 renamed Models folder to ViewModels in WebMVC 2017-03-03 16:00:15 +01:00
Carlos Cañizares Estévez
e4d3c66d27 Logout fix for Xamarin in identity 2016-12-19 17:55:48 +01:00
Carlos Cañizares Estévez
0a344f6cdc Improvements in identity, securice basket api, login-logout from mvc application and consume securiced basket. 2016-11-29 15:10:16 +01:00
Carlos Cañizares Estévez
6cff3aaf50 Basket microservice integration in MVC web, remove session from MVC Site, docker-compose to include Basket.api and Redis image. 2016-11-16 10:19:00 +01:00
Carlos Cañizares Estévez
1002356493 Fixed some issues in catalog filters and improve catalog views. 2016-11-07 18:37:11 +01:00
Carlos Cañizares Estévez
65e633e4e0 Add to Cart flow and views 2016-11-02 20:41:12 +01:00
Carlos Cañizares Estévez
b079e6ba79 Add Cart Flow 2016-10-31 17:56:24 +01:00
Carlos Cañizares Estévez
cbf3310cd1 Filter in product list and pagination 2016-10-31 09:25:47 +01:00
Carlos Cañizares Estévez
c424f0816a Web MVC site UI apperance 2016-10-21 05:46:30 +02:00