776 Commits

Author SHA1 Message Date
Eduard Tomàs
cc98475182 Merge pull request #126 from BillWagner/csharp7-on-mvcapp
C# 7 language feature updates
2017-03-21 13:32:05 +01:00
dsanz
8a689c45f2 Add Delete and Create actions to the CatalogController. 2017-03-21 13:10:40 +01:00
RamonTC
ec71fbb5ae Remove async await issue comments 2017-03-21 12:52:59 +01:00
RamonTC
8c6d880f18 Remove async await issue comments
Thanks for the review!
2017-03-21 12:51:25 +01:00
Cesar De la Torre
dd7de1be52 Removed not used Common folder from the Solution 2017-03-20 12:18:30 -07:00
Bill Wagner
00491910a2 C# 7 language feature updates
Controllers/AccountController:
Replace single line methods with expression bodied members.
Includes constructor, C# 7 feature.

Controllers/CatalogController:
Remove unnecessary ToString() call.
Replace single line methods with expression bodied members.

Extensions/HttpClientExtensions:
Replace single line methods with expression bodied members.

Extensions/SessionExtensions:
Replace single line methods with expression bodied members.

Services/BasketService:
Remove unnecessary ToString() calls.
Add ?? to simplify conditional initialization
Use TryGetValue and out variable initialization to simplify Quantity
calculation

Services/CatalogService:
Use Value<T> generic method instead of dynamic types.
There is a lot of overhead for dynamic and it seems overkill here.

Services/IdentityParser:
Use the pattern matching is expression.
Refactor the LINQ queries to enumerate the collection (and create an
enumerator)
only once. The previous code had 3 enumerations.

Services/Utilities/HttpApiClient:
Remove the 'async' modifier and 'await' statements from methods where
the only asynchronous statement is the final statement of the method,
and
the task from the underlying method can be returned.

Services/Utilities/HttpApiClientWrapper:
Use expression bodied members where applicable.
Remove the 'async' modifier and 'await' statements from methods where
the only asynchronous statement is the final statement of the method,
and
the task from the underlying method can be returned.

ViewComponents/Cart:
Use expression bodied members where applicable.

ViewComponents/CartList:
Use expression bodied members where applicable.
Remove the 'async' modifier and 'await' statements from methods where
the only asynchronous statement is the final statement of the method,
and
the task from the underlying method can be returned.

ViewModels/Annotations/CardExpiration:
Use the out variable initializer to simplify the validation of the
card expiration date.

ViewModels/Basket:
Use property initializer syntax instead of constructor body

ViewModels/CatalogViewModels/IndexViewModel:
Use expression bodied property to return the calculated 'Disabled'
property

ViewModels/Order:
Use property initializer syntax.
2017-03-20 14:18:20 -04:00
Cesar De la Torre
1e6954b529 Merge pull request #124 from dotnet/bugs/#72-SPAIssueWithNewestNodeVersions
Resolved SPA incompatibilities with dependencies
2017-03-20 11:14:55 -07:00
Cesar De la Torre
29dc6b41ca Merge pull request #123 from dotnet/bugs/61-AsyncSuffixNamingConvention
Fix #61 Async suffix for namig convention.
2017-03-20 10:59:07 -07:00
Cesar De la Torre
b1b7ca5a4c Merge pull request #122 from dotnet/bugs/#75-NoRetryLoginAtCatch
Removed the catch with retry logic from CatalogContextSeed
2017-03-20 10:49:34 -07:00
David Britch
433de15fdc Unused x:Name references removed. 2017-03-20 17:16:42 +00:00
David Britch
531e90e5a3 Removed unused services from view models. 2017-03-20 17:05:35 +00:00
David Britch
4a073b96d8 Removed unused code from NavigationService. 2017-03-20 16:58:37 +00:00
David Britch
33009ceb33 Renamed MessengerKeys class to MessageKeys. 2017-03-20 16:36:38 +00:00
David Britch
efa81cf842 ViewModelLocator is now responsible for connecting view models to views.
Uses an auto-wiring convention-based approach.
2017-03-20 16:31:35 +00:00
David Britch
721e35f724 Merge branch 'master' into xamarin 2017-03-20 16:02:48 +00:00
David Britch
00311b45d4 Replaced async void methods with async Task. 2017-03-20 15:51:05 +00:00
Ramón Tomás
66d612a826 Resolved SPA incompatibilities with dependencies when installing a newer node version 2017-03-20 16:46:57 +01:00
David Britch
561208ca81 AnimationExtension isn't used. 2017-03-20 15:42:24 +00:00
dsanz
de8aded2b0 Fix #61 Async suffix for namig convention. 2017-03-20 16:12:11 +01:00
Ramón Tomás
8a054ed349 Removed the catch with retry logic from CatalogContextSeed and create a retry loop at startup for db availability 2017-03-20 15:37:31 +01:00
Eduard Tomàs
5432936201 Merge pull request #120 from FDUdannychen/feature/ddd
use non generic repository interface
2017-03-20 15:33:35 +01:00
dsanz
ca029618e6 Fix for issue #57 When re-building the solution sometimes the FunctionalTests.csproj fails trying to find the Catalog.API.dll 2017-03-20 10:03:55 +01:00
Danny Chen
260df610b7 use non generic repository interface 2017-03-20 01:42:31 -04:00
Cesar De la Torre
aee1ac6a06 Domain Event Handlers refactored with some missing cases 2017-03-18 22:01:05 -07:00
Cesar De la Torre
3ed136b00f Domain Event Handlers are now grouped by Domain Events, as any Domain Event could have 'n' handlers related. 2017-03-18 11:44:18 -07:00
etomas
3ec61e0df6 Tried patch proposed by Sandeep Bansal 2017-03-18 11:13:20 +01:00
Cesar De la Torre
c7e317413e Refactoring Domain Events 2017-03-17 18:36:34 -07:00
etomas
cfecbc5dba Merge branch 'dev' of https://github.com/dotnet/eShopOnContainers into dev 2017-03-17 16:28:13 +01:00
etomas
9fdb5e6c96 FailingMiddleware for Ordering API 2017-03-17 16:28:05 +01:00
dsanz
a0da160a77 Merge from origin/dev to dev 2017-03-17 16:11:58 +01:00
dsanz
e996593d32 Add functional test for integration events. Implement IDisposable for EventBusRabbitMQ. 2017-03-17 15:57:57 +01:00
Ramón Tomás
bbc1481979 Removed event file from catalog api csproj 2017-03-17 13:20:52 +01:00
Ramón Tomás
15d0e98dd1 Merge branch 'polly-integration' into dev 2017-03-17 13:14:07 +01:00
Ramón Tomás
ddb03a0aa8 Refactoing HttpClientApi 2017-03-17 13:12:34 +01:00
Ramón Tomás
cb3f682872 Created Retry and CircuitBreaker policies for MVC App 2017-03-17 10:00:18 +01:00
Cesar De la Torre
5a374e97b5 Refactoring Integration Events so they cannot be confused with Domain Events 2017-03-16 18:59:20 -07:00
Cesar De la Torre
b9c1778d9d Refactoring Domain Events so it is clear and differenciated versus Integration Events 2017-03-16 18:52:02 -07:00
Cesar De la Torre
6f6f09e11e Minor refactoring on the Event Bus IntegrationEventLog 2017-03-16 15:54:01 -07:00
dsanz
33335eb230 Change in integration event publication fow as agreed. Flow is 1- start transaction 2- modify catalog iin db 3- add event to db 4- close transaction 5- publish event 6- update event state in db 2017-03-16 16:08:55 +01:00
dsanz
c8df9a232a Refactoring integration events: move event bus implementation to building block projects. 2017-03-16 13:30:01 +01:00
Cesar De la Torre
8423c8bb63 Larger Refactoring of IntegrationEvents 2017-03-15 18:42:47 -07:00
Cesar De la Torre
e41ce96f81 Minor refactoring related to the ProductPriceChanged integration event 2017-03-15 14:50:10 -07:00
dsanz
faf4ada8ac Fix unit tests 2017-03-15 15:32:13 +01:00
dsanz
f12f0c4ffa Fix merge issue 2017-03-15 15:18:06 +01:00
dsanz
d35cefb887 Fix merge issue. 2017-03-15 15:04:13 +01:00
DESKTOP-V1VLQ15\dsanz
6bd17ead80 Merge branch 'dev' of https://github.com/dotnet/eShopOnContainers into dev 2017-03-15 14:57:18 +01:00
DESKTOP-V1VLQ15\dsanz
0c4f8a49dd WebMVC and WebSPA show now a changed price in the basket list 2017-03-15 14:57:08 +01:00
Ramón Tomás
dbb4be8e47 Update ordering scenarios 2017-03-14 19:05:22 +01:00
Ramón Tomás
1e47a3378f Merge domain events to DEV 2017-03-14 19:04:59 +01:00
Ramón Tomás
9669d433a6 Added unit tests for entity domain events 2017-03-14 18:58:27 +01:00