From bc7b4cd272e202504969e2746ee020019861ee41 Mon Sep 17 00:00:00 2001
From: Suman991 <sumanmoni27@gmail.com>
Date: Thu, 16 Apr 2026 17:53:47 +0530
Subject: [PATCH] added Get api for some table

---
 src/conversations/conversations.controller.ts    | 16 ++++++++--------
 src/conversations/conversations.service.ts       | 10 +++++-----
 src/conversations/schemas/conversation.schema.ts |  2 +-
 src/users/users.controller.ts                    | 16 +++++++---------
 src/users/users.service.ts                       |  9 +++++++--
 5 files changed, 28 insertions(+), 25 deletions(-)

diff --git a/src/conversations/conversations.controller.ts b/src/conversations/conversations.controller.ts
index c228d20..52c5226 100644
--- a/src/conversations/conversations.controller.ts
+++ b/src/conversations/conversations.controller.ts
@@ -8,19 +8,19 @@ export class ConversationsController {
   constructor(private readonly conversationsService: ConversationsService) {}
 
   @Post()
-  create(@Body() createConversationDto: CreateConversationDto) {
-    return this.conversationsService.create(createConversationDto);
+  async create(@Body() createConversationDto: CreateConversationDto) {
+    return await this.conversationsService.create(createConversationDto);
   }
 
   @Get()
-  findAll() {
-    return this.conversationsService.findAll();
+  async findAll() {
+    return await this.conversationsService.findAll();
   }
 
-  @Get(':id')
-  findOne(@Param('id') id: string) {
-    return this.conversationsService.findOne(+id);
-  }
+  // @Get(':id')
+  // findOne(@Param('id') id: string) {
+  //   return this.conversationsService.findOne(+id);
+  // }
 
   @Patch(':id')
   update(@Param('id') id: string, @Body() updateConversationDto: UpdateConversationDto) {
diff --git a/src/conversations/conversations.service.ts b/src/conversations/conversations.service.ts
index d687cf0..4b07d3d 100644
--- a/src/conversations/conversations.service.ts
+++ b/src/conversations/conversations.service.ts
@@ -16,8 +16,8 @@ export class ConversationsService {
     return await this.conversationModel.create(createConversationDto)
   }
 
-  findAll() {
-    return `This action returns all conversations`;
+  async findAll():Promise<ConversationDocument[]> {
+    return await this.conversationModel.find().exec()
   }
   
   async findP2p(senderId:string, targetUserId:string){
@@ -27,9 +27,9 @@ export class ConversationsService {
     });
   }
 
-  findOne(id: number) {
-    return `This action returns a #${id} conversation`;
-  }
+  // findOne(id: number) {
+  //   return `This action returns a #${id} conversation`;
+  // }
 
   update(id: number, updateConversationDto: UpdateConversationDto) {
     return `This action updates a #${id} conversation`;
diff --git a/src/conversations/schemas/conversation.schema.ts b/src/conversations/schemas/conversation.schema.ts
index faaa915..c5f0b6d 100644
--- a/src/conversations/schemas/conversation.schema.ts
+++ b/src/conversations/schemas/conversation.schema.ts
@@ -5,7 +5,7 @@ export type ConversationDocument = Conversation & Document;
 export enum ConversationType{
     P2P='p2p',
     GROUP='group'
- }
+}
 
 @Schema({ timestamps: true })
 export class Conversation {
diff --git a/src/users/users.controller.ts b/src/users/users.controller.ts
index 92aee89..d011db0 100644
--- a/src/users/users.controller.ts
+++ b/src/users/users.controller.ts
@@ -2,24 +2,22 @@ import { Controller, Get, Post, Body, Patch, Param, Delete } from '@nestjs/commo
 import { UsersService } from './users.service';
 import { CreateUserDto } from './dto/create-user.dto';
 import { UpdateUserDto } from './dto/update-user.dto';
+import { ApiOperation } from '@nestjs/swagger';
 
 @Controller('users')
 export class UsersController {
   constructor(private readonly usersService: UsersService) {}
 
-  // @Post()
-  // create(@Body() createUserDto: CreateUserDto) {
-  //   return this.usersService.create(createUserDto);
-  // }
-
+  @ApiOperation({ summary: 'Get all users' })
   @Get()
-  findAll() {
-    return this.usersService.findAll();
+  async findAll() {
+    return await this.usersService.findAll();
   }
 
+  @ApiOperation({ summary: 'Get a user by id' })
   @Get(':id')
-  findOne(@Param('id') id: string) {
-    return this.usersService.findOne(id);
+  async findOne(@Param('id') id: string) {
+    return await this.usersService.findById(id);
   }
 
   // @Patch(':id')
diff --git a/src/users/users.service.ts b/src/users/users.service.ts
index 00ad1a2..8135004 100644
--- a/src/users/users.service.ts
+++ b/src/users/users.service.ts
@@ -15,10 +15,15 @@ export class UsersService {
     return await this.userModel.create(createUserDto)
   }
 
-  findAll() {
-    return `This action returns all users`;
+  async findAll():Promise<UserDocument[]> {
+    return await this.userModel.find().exec()
   }
 
+  async findById(id:string):Promise<UserDocument | null>{
+    return await this.userModel.findById(id).exec()
+  }
+
+  // NOTE:this is used in another module
   async findOne(name: string):Promise<UserDocument | null> {
     return await this.userModel.findOne({name}).exec()
   }