Browse Source

Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>
pull/1742/head
Sumit Ghosh 3 years ago
committed by GitHub
parent
commit
d1f711e85f
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 12 additions and 8 deletions
  1. +1
    -2
      src/Services/Basket/Basket.API/Auth/Server/AuthorizationHeaderParameterOperationFilter.cs
  2. +1
    -0
      src/Services/Basket/Basket.API/Infrastructure/Exceptions/FailingMiddlewareAppBuilderExtensions.cs
  3. +2
    -1
      src/Services/Basket/Basket.API/Infrastructure/Repositories/RedisBasketRepository.cs
  4. +1
    -1
      src/Services/Basket/Basket.API/IntegrationEvents/Events/OrderStartedIntegrationEvent.cs
  5. +1
    -1
      src/Services/Basket/Basket.API/IntegrationEvents/Events/ProductPriceChangedIntegrationEvent.cs
  6. +2
    -1
      src/Services/Basket/Basket.API/Model/BasketCheckout.cs
  7. +1
    -0
      src/Services/Basket/Basket.API/Model/BasketItem.cs
  8. +3
    -2
      src/Services/Basket/Basket.API/Model/CustomerBasket.cs

+ 1
- 2
src/Services/Basket/Basket.API/Auth/Server/AuthorizationHeaderParameterOperationFilter.cs View File

@ -10,8 +10,7 @@ public class AuthorizationHeaderParameterOperationFilter : IOperationFilter
if (isAuthorized && !allowAnonymous)
{
if (operation.Parameters == null)
operation.Parameters = new List<OpenApiParameter>();
operation.Parameters ??= new List<OpenApiParameter>();
operation.Parameters.Add(new OpenApiParameter


+ 1
- 0
src/Services/Basket/Basket.API/Infrastructure/Exceptions/FailingMiddlewareAppBuilderExtensions.cs View File

@ -6,6 +6,7 @@ public static class FailingMiddlewareAppBuilderExtensions
{
return UseFailingMiddleware(builder, null);
}
public static IApplicationBuilder UseFailingMiddleware(this IApplicationBuilder builder, Action<FailingOptions> action)
{
var options = new FailingOptions();


+ 2
- 1
src/Services/Basket/Basket.API/Infrastructure/Repositories/RedisBasketRepository.cs View File

@ -1,4 +1,5 @@
namespace Microsoft.eShopOnContainers.Services.Basket.API.Infrastructure.Repositories;
namespace Microsoft.eShopOnContainers.Services.Basket.API.Infrastructure.Repositories;
public class RedisBasketRepository : IBasketRepository
{
private readonly ILogger<RedisBasketRepository> _logger;


+ 1
- 1
src/Services/Basket/Basket.API/IntegrationEvents/Events/OrderStartedIntegrationEvent.cs View File

@ -1,7 +1,7 @@
namespace Basket.API.IntegrationEvents.Events;
// Integration Events notes:
// An Event is “something that has happened in the past”, therefore its name has to be
// An Event is "something that has happened in the past", therefore its name has to be
// An Integration Event is an event that can cause side effects to other microsrvices, Bounded-Contexts or external systems.
public record OrderStartedIntegrationEvent : IntegrationEvent
{


+ 1
- 1
src/Services/Basket/Basket.API/IntegrationEvents/Events/ProductPriceChangedIntegrationEvent.cs View File

@ -1,7 +1,7 @@
namespace Microsoft.eShopOnContainers.Services.Basket.API.IntegrationEvents.Events;
// Integration Events notes:
// An Event is “something that has happened in the past”, therefore its name has to be
// An Event is "something that has happened in the past", therefore its name has to be
// An Integration Event is an event that can cause side effects to other microsrvices, Bounded-Contexts or external systems.
public record ProductPriceChangedIntegrationEvent : IntegrationEvent
{


+ 2
- 1
src/Services/Basket/Basket.API/Model/BasketCheckout.cs View File

@ -1,4 +1,5 @@
namespace Basket.API.Model;
namespace Basket.API.Model;
public class BasketCheckout
{
public string City { get; set; }


+ 1
- 0
src/Services/Basket/Basket.API/Model/BasketItem.cs View File

@ -9,6 +9,7 @@ public class BasketItem : IValidatableObject
public decimal OldUnitPrice { get; set; }
public int Quantity { get; set; }
public string PictureUrl { get; set; }
public IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
{
var results = new List<ValidationResult>();


+ 3
- 2
src/Services/Basket/Basket.API/Model/CustomerBasket.cs View File

@ -1,9 +1,10 @@
namespace Microsoft.eShopOnContainers.Services.Basket.API.Model;
namespace Microsoft.eShopOnContainers.Services.Basket.API.Model;
public class CustomerBasket
{
public string BuyerId { get; set; }
public List<BasketItem> Items { get; set; } = new List<BasketItem>();
public List<BasketItem> Items { get; set; } = new();
public CustomerBasket()
{


Loading…
Cancel
Save